WIP feat(APP-3508): Remove title and description props from ProposalVoting module component #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekidnamedkd
changed the title
cgero-eth
reviewed
Oct 31, 2024
...dules/components/proposal/proposalVoting/proposalVotingContainer/proposalVotingContainer.tsx
Show resolved
Hide resolved
cgero-eth
changed the title
cgero-eth
reviewed
Nov 4, 2024
| <Heading size="h2">{title}</Heading> | ||
| <p className="text-base font-normal leading-normal text-neutral-500">{description}</p> | ||
| </div> | ||
| <Card className={classNames('flex w-full flex-col overflow-hidden', className)} {...otherProps}> |
There was a problem hiding this comment.
The full component alignment with the new design can be done later, but without the title and description the component looks off. We can probably update the paddings and gap to have a better temporary version of the component
|
Moving to WIP to double check with product if we should push this temporary design now or if we can postpone these changes to have the proper implementation later |
cgero-eth
changed the title
|
Closing as current implementation is okay for now and we'll use the APP-3508 ticket to update the UI with the new designs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove heading + desc from 'ProposalVoting' terminal
Task: APP-3508
Type of change
Checklist:
CHANGELOG.mdfile in the root folder of the package after the [UPCOMING] title and beforethe latest version.